Adjust the placement of the zero size check for some texture copies#8567
Merged
teoxoy merged 1 commit intogfx-rs:trunkfrom Nov 26, 2025
Merged
Adjust the placement of the zero size check for some texture copies#8567teoxoy merged 1 commit intogfx-rs:trunkfrom
teoxoy merged 1 commit intogfx-rs:trunkfrom
Conversation
cwfitzgerald
requested review from
cwfitzgerald
and removed request for
cwfitzgerald
teoxoy
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is important that we not call
handle_*_initif we are not actually going to perform a transfer.The order of operations is changed for
copy_texture_to_textureandcopy_external_image_to_texture. The rest are just adding the comment.Testing
Tested manually in Firefox.
Squash or Rebase? Squash
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.